Add DesugaringKind::FormatLiteral #142594
Conversation
|
r? @SparrowLii rustbot has assigned @SparrowLii. Use |
rustbot
added
S-waiting-on-review
|
Some changes occurred in compiler/rustc_ast_lowering/src/format.rs cc @m-ou-se |
|
We might want to block this on #140748, I'm relatively sure. Just FYI |
|
Why is that? |
|
Idk, if it's not conflicting according to git and if it's not stepping on each other's toes in other ways, I guess it's fine — I only skimmed boths diffs. Mara's PR will likely get approved soon anyway. |
compiler/rustc_trait_selection/src/error_reporting/traits/suggestions.rs
Show resolved
Hide resolved
mejrs
force-pushed
the
new_desugaring
branch
2 times, most recently
from
0cd0b91 to
3858b2c
Compare
| @@ -17,7 +19,9 @@ error[E0277]: `Bar` doesn't implement `Debug` | |||
| --> $DIR/no-debug.rs:10:32 | |||
| | | |||
| LL | println!("{:?} {:?}", Foo, Bar); | |||
| | ^^^ `Bar` cannot be formatted using `{:?}` because it doesn't implement `Debug` | |||
| | ---- ^^^ `Bar` cannot be formatted using `{:?}` because it doesn't implement `Debug` | |||
There was a problem hiding this comment.
It doesn't, but it does make that PR easier to implement; they can simply replace all of the diagnostic item stuff with a matches!(span.desugaring_kind(), Some(rustc_span::DesugaringKind::FormatLiteral {..}))
| @@ -4,9 +4,8 @@ error[E0277]: `a::Inner<T>` doesn't implement `Debug` | |||
| LL | #[derive(Debug)] | |||
| | ----- in this derive macro expansion | |||
| LL | struct Outer<T>(Inner<T>); | |||
| | ^^^^^^^^ `a::Inner<T>` cannot be formatted using `{:?}` | |||
| | ^^^^^^^^ the trait `Debug` is not implemented for `a::Inner<T>` | |||
There was a problem hiding this comment.
I'm neutral about this change. Maybe some beginners need to know the relationship between Debug and {:?}. I am not sure about this.
|
Looks ok for me. @bors delegate+ |
|
✌️ @mejrs, you can now approve this pull request! If @chenyukang told you to " |
bors
added
S-waiting-on-bors
Add DesugaringKind::FormatLiteral Implements `DesugaringKind::FormatLiteral` to mark the FormatArgs desugaring of format literals. The main use for this is to stop yapping about about formatting parameters if we're not anywhere near a format literal. The other use case is to fix suggestions such as rust-lang#141350. It might also be useful for new or existing diagnostics that check whether they're in a format-like macro. cc `@xizheyin` `@fmease`
Rollup of 10 pull requests Successful merges: - #140254 (Pass -Cpanic=abort for the panic_abort crate) - #142594 (Add DesugaringKind::FormatLiteral) - #142600 (Port `#[rustc_pub_transparent]` to the new attribute system) - #142617 (improve search graph docs, reset `encountered_overflow` between reruns) - #142641 (Generate symbols.o for proc-macros too) - #142747 (rustdoc_json: conversion cleanups) - #142776 (All HIR attributes are outer) - #142800 (integer docs: remove extraneous text) - #142850 (remove asm_goto feature annotation, for it is now stabilized) - #142860 (Notify me on tidy changes) r? `@ghost` `@rustbot` modify labels: rollup
bors
added
S-waiting-on-author
bors
added
S-waiting-on-bors
Implements
DesugaringKind::FormatLiteralto mark the FormatArgs desugaring of format literals. The main use for this is to stop yapping about about formatting parameters if we're not anywhere near a format literal. The other use case is to fix suggestions such as #141350. It might also be useful for new or existing diagnostics that check whether they're in a format-like macro.cc @xizheyin @fmease